Skip to content

Fix process of restore external-service instance#17194

Merged
JackieTien97 merged 1 commit intomasterfrom
fixExternalServiceStart
Feb 10, 2026
Merged

Fix process of restore external-service instance#17194
JackieTien97 merged 1 commit intomasterfrom
fixExternalServiceStart

Conversation

@Wei-hao-Li
Copy link
Collaborator

@Wei-hao-Li Wei-hao-Li commented Feb 10, 2026

  1. catch error when create instance
  2. omit null (means instance is not created) when stop instance

@Wei-hao-Li
fix
63dd3c1 
Signed-off-by: Weihao Li <18110526956@163.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link

codecov bot commented Feb 10, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.50%. Comparing base (c052179) to head (63dd3c1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ernalservice/ExternalServiceManagementService.java 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #17194      +/-   ##
============================================
- Coverage     39.51%   39.50%   -0.01%     
  Complexity      282      282              
============================================
  Files          5101     5101              
  Lines        341805   341804       -1     
  Branches      43518    43517       -1     
============================================
- Hits         135067   135045      -22     
- Misses       206738   206759      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackieTien97 JackieTien97 merged commit d5f9023 into master Feb 10, 2026
29 of 31 checks passed
@JackieTien97 JackieTien97 deleted the fixExternalServiceStart branch February 10, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JackieTien97 JackieTien97 JackieTien97 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wei-hao-Li @JackieTien97